Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Node.readInlineContent() implementation #577

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Sep 4, 2024

Instead of building an iterator, then transforming it to a list, it now directly builds a list from the content.

Fixes #458

Instead of building an iterator, then transforming it to a list, it now
directly builds a list from the content.
@rock3r rock3r added the cleanup Improve the project/tooling and/or get rid of tech debt label Sep 4, 2024
@rock3r rock3r requested a review from hamen September 4, 2024 10:40
@rock3r rock3r self-assigned this Sep 4, 2024
@rock3r rock3r enabled auto-merge (squash) September 4, 2024 10:40
Copy link
Collaborator

@hamen hamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@rock3r rock3r merged commit 8e12870 into main Sep 4, 2024
1 check passed
@rock3r rock3r deleted the 458-improve-readInlineContent branch September 4, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improve the project/tooling and/or get rid of tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants